Re: [Buildroot] [PATCH 2/2] package/snappy: fix compilation error raised by vqtbl1q_u8 instruction

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-amarula@amarulasolutions.com,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/snappy: fix compilation error raised by vqtbl1q_u8 instruction
Date: Wed, 10 Jul 2024 14:37:55 +0200	[thread overview]
Message-ID: <20240710143755.7a0ad71f@windsurf> (raw)
In-Reply-To: <20240611171714.3233115-2-dario.binacchi@amarulasolutions.com>

Hello Dario,

On Tue, 11 Jun 2024 19:17:14 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> The package compilation for the raspberrypi3_qt5we_defconfig raises the
> following error:
> 
> In file included from buildroot/output/build/snappy-1.2.1/snappy.cc:29:
> buildroot/output/build/snappy-1.2.1/snappy-internal.h: In function ‘snappy::internal::V128 snappy::internal::V128_Shuffle(V128, V128)’:
> buildroot/output/build/snappy-1.2.1/snappy-internal.h:109:10: error: ‘vqtbl1q_u8’ was not declared in this scope; did you mean ‘vtbl1_u8’?
>   109 |   return vqtbl1q_u8(input, shuffle_mask);
>       |          ^~~~~~~~~~
>       |          vtbl1_u8
> make[4]: *** [CMakeFiles/snappy.dir/build.make:118: CMakeFiles/snappy.dir/snappy.cc.o] Error 1
> 
> The added patch fixes the error.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Thanks for this patch and the related investigation. However, there is
an issue in how this fix is articulated with your version bump in PATCH
1/2. Indeed there are two possibilities:

- The build error with the NEON instruction is introduced by the bump
  to version 1.2.1. In this case, the patch fixing the build error
  should be in the patch doing the bump.

- The build error with the NEON instruction already exists in the
  currently packaged 1.1.10 version of snappy. In that case, the patch
  fixing the issue should come *before* the version bump in your
  series, and should indicate *when* the build error was introduced, so
  that we know if the fix should be backported to Buildroot LTS
  branches.

Could you have a look into this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot