Re: [Buildroot] [PATCH 1/1] package/sunxi-mali-utgard-driver: fix patch fuzz

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Arnout,

On Thu, 11 Jul 2024 11:51:11 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

> > Thanks for the patch, but I'm not entirely sure that's how we want to
> > fix this issue. Indeed, apply-patches is used in quite a lot of
> > packages to apply patches from Debian. Do we want to fix all those
> > patches, like you did for the sunxi-mali-utgard-driver? I'm not sure.  
> 
>   AFAIK, Debian patches should apply without fuzz (unless we do stupid stuff 
> like applying our own patches first).

Is this "should" based on actual experimentation/validation, or just
some general assumption?

>   I think this is the only case where we are downloading patches that have 
> incorrect fuzz - or did you encounter any other case, Dario?
> 
>   And in this specific case, upstream is Giulio, so I expect that the PR will be 
> accepted soon and we can simply bump.

Ah, I didn't realize we had an active upstream for this package.
Indeed, it means we will be able to drop our patch.

>   I agree, but only if we actually encounter a situation where this is the case. 
> Note that the implementation will not be super trivial (will require something 
> like FOO_APPLY_PATCHES_FUZZ).

Well, no, I was assuming $(APPLY_PATCHES) that is used in packages
would default to accepting fuzz, and only the $(APPLY_PATCHES) call in
our package infra, which applies our patches, would pass an option to
disable fuzz.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot