Re: [Buildroot] [PATCH 3/4] package/python-ruamel-yaml-clib: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Marcus Hoffmann <buildroot@bubu1.eu>,
	Asaf Kahlon <asafka7@gmail.com>
Subject: Re: [Buildroot] [PATCH 3/4] package/python-ruamel-yaml-clib: new package
Date: Fri, 12 Jul 2024 15:23:24 +0200	[thread overview]
Message-ID: <20240712152324.262c5edd@windsurf> (raw)
In-Reply-To: <20240207170959.2672846-3-buildroot@bubu1.eu>

Hello Marcus,

On Wed,  7 Feb 2024 18:09:55 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/python-ruamel-yaml-clib/Config.in b/package/python-ruamel-yaml-clib/Config.in
> new file mode 100644
> index 0000000000..a06080873f
> --- /dev/null
> +++ b/package/python-ruamel-yaml-clib/Config.in
> @@ -0,0 +1,9 @@
> +if BR2_PACKAGE_PYTHON_RUAMEL_YAML
> +config BR2_PACKAGE_PYTHON_RUAMEL_YAML_CLIB
> +	bool "python-ruamel-yaml-clib"

Changed the if BR2_PACKAGE_PYTHON_RUAMEL_YAML to a depends on
BR2_PACKAGE_PYTHON_RUAMEL_YAML, which is more common for this type of
situation IMO.

> diff --git a/package/python-ruamel-yaml-clib/python-ruamel-yaml-clib.mk b/package/python-ruamel-yaml-clib/python-ruamel-yaml-clib.mk
> new file mode 100644
> index 0000000000..3e5434fa9a
> --- /dev/null
> +++ b/package/python-ruamel-yaml-clib/python-ruamel-yaml-clib.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# python-ruamel-yaml

Bad copy/paste, should have been python-ruamel-yaml-clib.

> +#
> +################################################################################
> +
> +PYTHON_RUAMEL_YAML_CLIB_VERSION = 0.2.8
> +PYTHON_RUAMEL_YAML_CLIB_SOURCE = ruamel.yaml.clib-$(PYTHON_RUAMEL_YAML_CLIB_VERSION).tar.gz
> +PYTHON_RUAMEL_YAML_CLIB_SITE = https://files.pythonhosted.org/packages/46/ab/bab9eb1566cd16f060b54055dd39cf6a34bfa0240c53a7218c43e974295b
> +PYTHON_RUAMEL_YAML_CLIB_SETUP_TYPE = setuptools
> +PYTHON_RUAMEL_YAML_CLIB_LICENSE = MIT
> +PYTHON_RUAMEL_YAML_CLIB_LICENSE_FILES = LICENSE
> +PYTHON_RUAMEL_YAML_CLIB_CPE_ID_VENDOR = ruamel.yaml_project
> +PYTHON_RUAMEL_YAML_CLIB_CPE_ID_PRODUCT = ruamel.yaml

I dropped those two lines. Indeed, the CPE vendor/product (at least
product) cannot be the same as for python-ruamel-yaml, as they have
different versioning.

Also, the entry in the DEVELOPERS file was missing, so I added it.

Applied with those fixes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot