Re: [Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Raphael,

Thanks for your patch. See below a review.

On Fri, 12 Jul 2024 20:27:12 +0200
Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:

> Base config on latest kernel version available.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
>  configs/stm32mp157c_dk2_defconfig | 20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
> index c48705b2fb..0e26042b90 100644
> --- a/configs/stm32mp157c_dk2_defconfig
> +++ b/configs/stm32mp157c_dk2_defconfig
> @@ -1,31 +1,17 @@
> -# Architecture
>  BR2_arm=y
>  BR2_cortex_a7=y
> -
> -# Linux headers same as kernel, a 5.13 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y

Please keep the comments and this option (but updated). It seems like
you did a "make savedefconfig", without really worrying about what
changed.

> -
> -# System configuration
>  BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
> -
> -# Kernel
>  BR2_LINUX_KERNEL=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"

We need to keep an explicit kernel version, so that it doesn't
automatically uses the "latest".

I believe it would also make sense to update TF-A and U-Boot at the
same time.

Could you fix up those details, and submit an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot