Re: [Buildroot] [PATCH v3 1/1] package/docker-cli-buildx: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 23 Jul 2023 18:09:07 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> buildx is a docker CLI plugin implementing extended build features.
> 
> buildx is the default builder as of Docker v23.x, and if the plugin is not
> present, the CLI will output an error warning that it is using the deprecated
> built-in builder instead of the buildx builder.
> 
> However, buildx is a separate repository from docker-cli: it is a plugin that
> needs to be installed at /usr/lib/docker/cli-plugins on the target.
> 
> https://github.com/docker/buildx
> 
> Signed-off-by: Christian Stewart <christian@aperture.us>
> 
> ---

Sorry for the super long delay: patch applied. I'm sure you'll need to
send a version bump :)

Perhaps with a version bump this part:

+# create the go.mod file with required language version go1.20
+# remove the conflicting vendor/modules.txt
+# https://github.com/moby/moby/issues/44618#issuecomment-1343565705
+define DOCKER_CLI_BUILDX_FIX_VENDORING
+	printf "module $(DOCKER_CLI_BUILDX_GOMOD)\n\ngo 1.20\n" > $(@D)/go.mod
+	rm -f $(@D)/vendor/modules.txt
+endef
+DOCKER_CLI_BUILDX_POST_EXTRACT_HOOKS += DOCKER_CLI_BUILDX_FIX_VENDORING

can do away or be tweaked?

Thanks a lot, and again sorry for the delay.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot