From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176
Date: Sat, 13 Jul 2024 14:15:29 +0200 [thread overview]
Message-ID: <20240713141529.66e77cea@windsurf> (raw)
In-Reply-To: <20240712201943.457747-1-james.hilliard1@gmail.com>
Hello James,
On Fri, 12 Jul 2024 14:19:43 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
It would have been *really* nice if you could have pointed out that
this commit fixes a build issue that was occurring in the autobuilder.
The only commit brought by your version bump is an upstream commit of
you to fix the build issue, but you did not even mention it here.
This fixes:
http://autobuild.buildroot.net/results/e0f46983dafdc7d309e6cdfdeda268c582a03156/build-end.log
which was occurring with version
440c0059a21f06b5577499a80b55482cb99d6d1c.
But also fixes:
http://autobuild.buildroot.net/results/a9de4890fd2499842a26abc8f595f43206e4bdc1/build-end.log
which was occurring with the previous version,
a853a5d715d84eec93aa68e8f2df26b7d860f5b2.
Peter: it means this version bump is actually fixing an issue that
occurs on 2024.02, so this version bump should be backported to our LTS
branch.
James: this is why we ask for more explanations, so that we can figure
out whether a certain commit is relevant or not for our LTS branch.
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-13 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 20:19 [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176 James Hilliard
2024-07-12 20:54 ` Thomas Petazzoni via buildroot
2024-07-13 12:15 ` Thomas Petazzoni via buildroot [this message]
2024-07-13 17:47 ` James Hilliard
2024-07-13 19:53 ` Thomas Petazzoni via buildroot
2024-07-14 13:24 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713141529.66e77cea@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox