Re: [Buildroot] [PATCH] package/pkg-utils: add 'hash_files' to show-info

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Brandon,

Thanks for your patch! Questions/comments below.

On Tue, 28 May 2024 15:29:48 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Brandon Maier <brandon.maier@collins.com>

Could you expand a bit the commit log to describe the motivation for
this change? What are the use-cases?

> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index d1964299af..8970a2a8b9 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -176,6 +176,13 @@ define _json-info-pkg-details
>  		},
>  	)
>  	],
> +	"hash_files": [
> +		$(foreach f, $($(1)_HASH_FILES),$(call mk-json-str,$(f))$(comma))
> +	],

One thing that isn't that "useful" here is that this is going to list
*all* hash files for that package, not the one hash file that contained
the appropriate hash used to check the package (if there are multiple
hash files).

> +	"no_check_hash_for": \
> +		$(if $(BR2_DOWNLOAD_FORCE_CHECK_HASHES), \
> +			false, \
> +			$(if $(filter $($(1)_SOURCE),$(BR_NO_CHECK_HASH_FOR)),true,false)),

Could we have positive logic instead, such as "hash-checked": true?

Also, here you're basing the value of this property solely on whether
<pkg>_SOURCE was hash-checked. But what about <pkg>_PATCH and
<pkg>_EXTRA_DOWNLOADS? So basically this should be true only if all
files in <pkg>_ALL_DOWNLOADS have been hash-checked.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot