Re: [Buildroot] [PATCH] package/tar: fix linking with libiconv

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/tar: fix linking with libiconv
Date: Mon, 15 Jul 2024 10:28:48 +0200	[thread overview]
Message-ID: <20240715102848.7dc3d619@windsurf> (raw)
In-Reply-To: <20240630210938.1590435-1-yann.morin.1998@free.fr>

Hello Yann,

On Sun, 30 Jun 2024 23:09:38 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Backport two patches from upstream to fix linking with libiconv, e.g.
> with this defconfig:
> 
>     BR2_TOOLCHAIN_BUILDROOT_UCLIBC=y
>     BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>     BR2_SYSTEM_ENABLE_NLS=y
>     BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
>     BR2_PACKAGE_LIBICONV=y
>     BR2_PACKAGE_TAR=y
> 
> It is interesting to note that the first patch we backport is the first
> commit in the tar repository after the 1.35 tag, and was comitted the
> same day the release was cut...
> 
> Fixes: #4

I've changed this to:

    Fixes:

     https://gitlab.com/buildroot.org/buildroot/-/issues/4
     http://autobuild.buildroot.net/results/c074c2e22a7f764400ecc7dd1a6cd6022fa87fb9/

I don't know if Peter will agree, but I find the full URL to the gitlab
issue to be clearer. One can directly click, we can more easily grep
through the git commit messages to find all commits that fix a Gitlab
issue, etc.

And of course, I've added an autobuilder failure.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot