Re: [Buildroot] [PATCH] dhrystone: add patch with forward declarations for functions

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Thu, 27 Jun 2024 12:34:40 +0200
Steffen Persvold <spersvold@gmail.com> wrote:

> GCC14 will give errors for missing function declarations and
> missing return types :
> 
> dhry_1.c:75:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>    75 | main(int argc, char *argv[])
>       | ^~~~
> dhry_1.c: In function ‘main’:
> dhry_1.c:159:5: error: implicit declaration of function ‘Proc_5’ [-Wimplicit-function-declaration]
>   159 |     Proc_5();
>       |     ^~~~~~
> 
> Signed-off-by: Steffen Persvold <spersvold@gmail.com>
> ---
>  package/dhrystone/0006-fwd-decl.patch | 121 ++++++++++++++++++++++++++
>  1 file changed, 121 insertions(+)
>  create mode 100644 package/dhrystone/0006-fwd-decl.patch

Thanks for your contribution!

The patch added by your patch was missing a Signed-off-by line and an
Upstream tag, so I've added that. Also your commit message was missing
a reference to the autobuilder failure being fixed by this. I addressed
both issues when applying.

I did a preparation patch to clean-up the existing patches a bit:

  https://gitlab.com/buildroot.org/buildroot/-/commit/95013777cf93548eee7ac3010b513d354e8b0a30

And then applied your patch with the fixes described above:

  https://gitlab.com/buildroot.org/buildroot/-/commit/3847a145c23234b3bddae3a9ceb9d2d4e6a90fc5

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot