Re: [Buildroot] [PATCH 1/1] package/openssh: refactor S50sshd

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Nicolas,

On Thu, 23 Nov 2023 11:39:52 +0100
Nicolas Cavallari <nicolas.cavallari@green-communications.fr> wrote:

> Make it look more like the example S01syslogd shell script in
> docs/manual/adding-packages-directory.txt.
> 
> Functionnally, it changes the following:
> - Options can be defined in /etc/default/sshd
> - "S50sshd stop" will no longer kill active SSH sessions or sshd daemons
>   that run inside a container or chroot.  It is now safe to stop or
>   restart openssh inside an SSH session.
> - "S50sshd restart" now sleeps between stop and start, reducing the
>   probability of failures caused by sshd taking too much time to stop.
> - "S50sshd reload" will send a SIGHUP instead of restarting sshd.
> - /var/lock/sshd is no longer created.  The daemon does not use it.
>   The only reference to /var/lock is in contrib/redhat/sshd.init, which
>   uses it as a way to test if sshd is (supposed to be) running.
> 
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
>  package/openssh/S50sshd | 75 +++++++++++++++++++++++++++--------------
>  1 file changed, 49 insertions(+), 26 deletions(-)

Sorry for the slow feedback. There's been more recent discussion
related to init scripts, and these lead to changes in S01syslogd, and a
following improvement of S50sshd to align it with the changes in
S01syslogd. Therefore your patch is in fact no longer needed I believe,
but don't hesitate to check if S50sshd is OK.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot