From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: Samuel Martin <s.martin49@gmail.com>,
Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH v2 2/2] package/picotool: new package
Date: Mon, 15 Jul 2024 21:45:30 +0200 [thread overview]
Message-ID: <20240715214530.18b1ce0f@windsurf> (raw)
In-Reply-To: <20240228202414.719244-2-buildroot@bubu1.eu>
Hello Marcus,
On Wed, 28 Feb 2024 21:24:13 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> package/Config.in | 1 +
> package/picotool/Config.in | 16 ++++++++++++++++
> package/picotool/picotool.hash | 3 +++
> package/picotool/picotool.mk | 15 +++++++++++++++
> 4 files changed, 35 insertions(+)
> create mode 100644 package/picotool/Config.in
> create mode 100644 package/picotool/picotool.hash
> create mode 100644 package/picotool/picotool.mk
Entry in the DEVELOPERS file was missing, so I added one.
> diff --git a/package/picotool/picotool.mk b/package/picotool/picotool.mk
> new file mode 100644
> index 0000000000..c98284c491
> --- /dev/null
> +++ b/package/picotool/picotool.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# picotool
> +#
> +################################################################################
> +
> +PICOTOOL_VERSION = 1.1.2
> +PICOTOOL_SITE = https://github.com/raspberrypi/picotool/archive/refs/tags
This should have used the $(call github,...) macro since they don't
provide specific tarballs other than the auto-generated ones.
> +PICOTOOL_SOURCE = $(PICOTOOL_VERSION).tar.gz
This can therefore go.
> +PICOTOOL_CONF_OPTS = -DPICO_SDK_PATH=$(STAGING_DIR)/usr/include/pico-sdk
And this had to be adjusted to usr/share/pico-sdk.
Applied with those minor fixes. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-15 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 20:24 [Buildroot] [PATCH v2 1/2] package/pico-sdk: new package Marcus Hoffmann via buildroot
2024-02-28 20:24 ` [Buildroot] [PATCH v2 2/2] package/picotool: " Marcus Hoffmann via buildroot
2024-07-12 13:28 ` Thomas Petazzoni via buildroot
2024-07-15 18:31 ` Marcus Hoffmann via buildroot
2024-07-15 19:45 ` Thomas Petazzoni via buildroot [this message]
2024-07-15 19:44 ` [Buildroot] [PATCH v2 1/2] package/pico-sdk: " Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715214530.18b1ce0f@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@bubu1.eu \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox