Re: [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Andreas,

On Wed, 17 Jul 2024 21:48:08 +0200
Andreas Naumann <anaumann@ultratronik.de> wrote:

> Add qt6 version of qtopcua from git as it's not contained in the
> official qt release submodule directory.
> 
> Fulfill the mandatory dependency on qt6base, and qt6base-network in
> particular, as well as the need for host tool qopcuaxmldatatypes2cpp
> which is provided by host-qt6opcua.
> For host-qt6opcua set the dependency on host-qt6base-network as well.
> 
> Existence of the optional dependency openssl enables
> FEATURE_open62541_security. (This has changed from qt5opcua where
> mbedtls was supported.)
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>

Thanks applied, with minor changes, see below.

> ---
>  package/qt6/Config.in              |  1 +
>  package/qt6/qt6opcua/Config.in     | 14 +++++++++
>  package/qt6/qt6opcua/qt6opcua.hash |  9 ++++++
>  package/qt6/qt6opcua/qt6opcua.mk   | 46 ++++++++++++++++++++++++++++++
>  4 files changed, 70 insertions(+)

Entry in DEVELOPERS file missing.



>  create mode 100644 package/qt6/qt6opcua/Config.in
>  create mode 100644 package/qt6/qt6opcua/qt6opcua.hash
>  create mode 100644 package/qt6/qt6opcua/qt6opcua.mk
> 
> diff --git a/package/qt6/Config.in b/package/qt6/Config.in
> index e84806d5e4..29c1c25c7f 100644
> --- a/package/qt6/Config.in
> +++ b/package/qt6/Config.in
> @@ -48,6 +48,7 @@ source "package/qt6/qt6core5compat/Config.in"
>  source "package/qt6/qt6declarative/Config.in"
>  source "package/qt6/qt6languageserver/Config.in"
>  source "package/qt6/qt6mqtt/Config.in"
> +source "package/qt6/qt6opcua/Config.in"
>  source "package/qt6/qt6serialbus/Config.in"
>  source "package/qt6/qt6serialport/Config.in"
>  source "package/qt6/qt6shadertools/Config.in"
> diff --git a/package/qt6/qt6opcua/Config.in b/package/qt6/qt6opcua/Config.in
> new file mode 100644
> index 0000000000..84a51f544f
> --- /dev/null
> +++ b/package/qt6/qt6opcua/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_QT6OPCUA
> +	bool "qt6opcua"
> +	select BR2_PACKAGE_QT6BASE_NETWORK
> +        # qt6opcuda needs host-qt6opcua, and host-qt6opcua needs
> +        # network support in qt6base.

Dang, I realize now the indentation here is with spaces, it should have
been with tabs. I'll fix that up.


> +QT6OPCUA_LICENSE = \
> +	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
> +	GPL-3.0 WITH Qt-GPL-exception-1.0 (tools), \

The tools are also under "GPL-2.0 or GPL-3.0 or LGPL-3.0" as far I can
see, so I dropped this line.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot