Re: [Buildroot] [PATCH v1] package/cairo: fix compilation on toolchains without c++ support

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for the investigation, I had come to the same conclusion earlier
today, but you were faster than me at cooking the patch. A couple of
comments below, though, for your future contributions.

On Thu, 18 Jul 2024 12:19:55 +0000
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 

When you submit a fix, you should always explain since when the
regression got introduced. Indeed, Peter Korsgaard reviews all commits
made on master, and has to decide which commits should be backported to
our 2024.02.x maintenance branch. So we need to know if this fix is
needed on 2024.02.x or not. In this, it is not needed. So I have added
this in the commit message:

    This issue was occurring since the conversion of cairo to
    meson-package in commit
    1fa58814c09a71444f961b61a9a2c399b9163fc2 ("package/cairo: move to the
    meson build system")

> Fixes:
>  - https://lore.kernel.org/buildroot/20240717200926.1a7db2a1@windsurf/

Here, we want a reference to an autobuilder failure, so:

    Fixes:
    
      http://autobuild.buildroot.net/results/98b62ab7ed3092f9f9085f723baf7d6267451e5c/
    

> diff --git a/package/cairo/0003-meson-only-require-cpp-for-windows.patch b/package/cairo/0003-meson-only-require-cpp-for-windows.patch
> new file mode 100644
> index 0000000000..9774f29f8c
> --- /dev/null
> +++ b/package/cairo/0003-meson-only-require-cpp-for-windows.patch
> @@ -0,0 +1,38 @@
> +From e93ef3feb69994e3aa4e0ab66ccd66139b097e49 Mon Sep 17 00:00:00 2001
> +From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> +Date: Thu, 18 Jul 2024 12:16:51 +0200
> +Subject: [PATCH] meson: only require cpp for windows
> +
> +Allow to compile meson without c++ toolchain.

No, it's cairo that you allow to build without C++.

> +Fixes:
> + - https://lore.kernel.org/buildroot/20240717200926.1a7db2a1@windsurf/

We also recommend a reference to an autobuilder failure, or even better
as this patch goes upstream (which doesn't care about Buildroot),
directly have the error message copy/pasted.

I've applied with those details fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot