Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bryce Johnson <bryce@redpinelabs.com>
Cc: martin@barkynet.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/connman: Remove wpa_supplicant selection for wifi
Date: Thu, 18 Jul 2024 22:10:39 +0200	[thread overview]
Message-ID: <20240718221039.497a60bf@windsurf> (raw)
In-Reply-To: <CADXxVSLCUVvO1MwirtFrxfX8QFP4=N7S49xswD=j1oSrV=6PSg@mail.gmail.com>

Hello Bryce,

On Thu, 18 Jul 2024 09:15:16 -0600
Bryce Johnson <bryce@redpinelabs.com> wrote:

> Connman wifi works both with IWD and wpa_supplicant
> 
> Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
> ---
>  package/connman/Config.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index af3e1f69f6..62516d435f 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -45,8 +45,7 @@ config BR2_PACKAGE_CONNMAN_ETHERNET
> 
>  config BR2_PACKAGE_CONNMAN_WIFI
>      bool "enable WiFi support"
> -    select BR2_PACKAGE_WPA_SUPPLICANT # runtime
> -    select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime
> +    select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD #runtime

But what about BR2_PACKAGE_WPA_SUPPLICANT_DBUS ?

Don't we need to also have:

	select BR2_PACKAGE_WPA_SUPPLICANT_DBUS if !BR2_PACKAGE_IWD # runtime

to preserve the same behavior?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-07-18 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 21:14 [Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi Bryce Johnson
2024-07-18 10:04 ` Arnout Vandecappelle via buildroot
2024-07-18 14:42   ` Bryce Johnson
2024-07-18 15:15     ` [Buildroot] [PATCH v2 1/1] " Bryce Johnson
2024-07-18 20:10       ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718221039.497a60bf@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bryce@redpinelabs.com \
    --cc=martin@barkynet.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox