From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Brandon Maier <brandon.maier@collins.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] boot/uboot: fix Kconfig warning for DEFAULT_ENV_FILE
Date: Fri, 19 Jul 2024 18:33:51 +0200 [thread overview]
Message-ID: <20240719183351.47713dd7@booty> (raw)
In-Reply-To: <20240719-boot-uboot-env-select-v2-1-6abcd50db794@collins.com>
Hi Brandon,
On Fri, 19 Jul 2024 14:50:26 +0000
Brandon Maier <brandon.maier@collins.com> wrote:
> The following warning occurs from commit "boot/uboot: allow taking the
> entire default environment from a text file".
>
> boot/uboot/Config.in:141:warning: config symbol
> 'BR2_TARGET_UBOOT_DEFAULT_ENV_FILE' uses select, but is not bool or
> tristate
>
> Add a hidden 'bool' config so we can enable dependencies.
>
> In addition, the DEFAULT_ENV_FILE works by setting Kconfig options,
> therefore we also need to depend on
> BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG.
>
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
Thanks for addressing this so quickly!
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-19 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 14:50 [Buildroot] [PATCH v2] boot/uboot: fix Kconfig warning for DEFAULT_ENV_FILE Brandon Maier via buildroot
2024-07-19 16:33 ` Luca Ceresoli via buildroot [this message]
2024-07-19 20:32 ` Thomas Petazzoni via buildroot
2024-07-20 9:36 ` Luca Ceresoli via buildroot
2024-07-22 16:29 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719183351.47713dd7@booty \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=luca.ceresoli@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox