From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cpuload: fix build with gcc >= 14
Date: Sat, 20 Jul 2024 22:52:25 +0200 [thread overview]
Message-ID: <20240720225225.5ace40cd@windsurf> (raw)
In-Reply-To: <20240720124008.460751-1-fontaine.fabrice@gmail.com>
On Sat, 20 Jul 2024 14:40:08 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure with gcc >= 14:
>
> read_cpu_stat.c: In function 'cpudata_new':
> read_cpu_stat.c:49:17: error: implicit declaration of function 'error'; did you mean 'perror'? [-Wimplicit-function-declaration]
> 49 | error("too many cpus");
> | ^~~~~
> | perror
>
> Fixes:
> - http://autobuild.buildroot.org/results/3bca2659011d123d7b7a0ca19c4e868643d45766
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> .../0001-Changed-error-calls-to-perror.patch | 115 ++++++++++++++++++
> 1 file changed, 115 insertions(+)
> create mode 100644 package/cpuload/0001-Changed-error-calls-to-perror.patch
The patch is a bit noisy with some changes to the .gitignore file that
are clearly unrelated. But OK, that's the patch as it was submitted
upstream, so fine.
Maybe you should react on the pull request, with a thumbs up or a
positive comment, saying it also fixes problems we are seeing?
Thanks, patch applied!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-20 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 12:40 [Buildroot] [PATCH 1/1] package/cpuload: fix build with gcc >= 14 Fabrice Fontaine
2024-07-20 20:52 ` Thomas Petazzoni via buildroot [this message]
2024-08-29 6:06 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720225225.5ace40cd@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox