From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Steve James <ste@junkomatic.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libcli: fix build with gcc >= 14
Date: Sat, 20 Jul 2024 23:01:47 +0200 [thread overview]
Message-ID: <20240720230147.1e29731b@windsurf> (raw)
In-Reply-To: <20240720093743.259131-1-fontaine.fabrice@gmail.com>
On Sat, 20 Jul 2024 11:37:43 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure with gcc >= 14:
>
> libcli.c: In function 'cli_register_command':
> libcli.c:430:27: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
> 430 | if (!(c = calloc(sizeof(struct cli_command), 1))) return NULL;
> | ^~~~~~
> libcli.c:430:27: note: earlier argument should specify number of elements, later size of each element
>
> Fixes:
> - http://autobuild.buildroot.org/results/a170d27689e069cf58f830bdd74f604364ee503b
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...rameters-for-Wcalloc-transposed-args.patch | 96 +++++++++++++++++++
> 1 file changed, 96 insertions(+)
> create mode 100644 package/libcli/0001-Swap-calloc-parameters-for-Wcalloc-transposed-args.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-20 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 9:37 [Buildroot] [PATCH 1/1] package/libcli: fix build with gcc >= 14 Fabrice Fontaine
2024-07-20 21:01 ` Thomas Petazzoni via buildroot [this message]
2024-08-29 6:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720230147.1e29731b@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=ste@junkomatic.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox