From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andreas Ziegler <br015@umbiko.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mpd: rebase init script on layout introduced by openssh
Date: Sun, 21 Jul 2024 18:23:42 +0200 [thread overview]
Message-ID: <20240721182342.6403c1d7@windsurf> (raw)
In-Reply-To: <20240721065737.2744-1-br015@umbiko.net>
Hello Andreas,
On Sun, 21 Jul 2024 08:57:37 +0200
Andreas Ziegler <br015@umbiko.net> wrote:
> + printf "Starting %s: " "$DAEMON"
> + # $DAEMON creates its own $PIDFILE, so do not use --pidfile
Not correct: you still need to use --pidfile. --pidfile does not tell
start-stop-daemon to create the PID file, but it will check whether the
process really created it.
OpenSSH also creates its own PID file, so could you rework to really
follow the S50sshd example?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-21 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 6:57 [Buildroot] [PATCH] package/mpd: rebase init script on layout introduced by openssh Andreas Ziegler
2024-07-21 16:23 ` Thomas Petazzoni via buildroot [this message]
2024-07-21 17:36 ` [Buildroot] [PATCH v2] " Andreas Ziegler
2024-07-22 12:15 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240721182342.6403c1d7@windsurf \
--to=buildroot@buildroot.org \
--cc=br015@umbiko.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox