From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Matt Flax <flatmax@flatmax.org>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gtkiostream: disable octave
Date: Mon, 22 Jul 2024 14:10:24 +0200 [thread overview]
Message-ID: <20240722141024.3be863b1@windsurf> (raw)
In-Reply-To: <20240722082154.721778-1-fontaine.fabrice@gmail.com>
On Mon, 22 Jul 2024 10:21:54 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Disable octave support which was added in commit
> fab48302865e5c0c98d91b696bc90e75e38189bb but untested as octave is not
> installed to staging and raises the following build failure:
>
> sparc64-linux-g++: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/octave-3.8.1'
>
> Fixing those issues is useless, as gtkiostream is not compatible with
> latest octave version as it raises a bunch of errors:
>
> Octave.C: In member function 'void Octave::startOctave(const std::vector<std::__cxx11::basic_string<char> >&)':
> Octave.C:85:5: error: 'octave_main' was not declared in this scope; did you mean 'octave_map'?
> 85 | octave_main((int)argsIn.size(), (char**)&argsIn[0], embedded);
> | ^~~~~~~~~~~
> | octave_map
> Octave.C: In member function 'int Octave::setGlobalVariable(const std::string&, Matrix&)':
> Octave.C:283:50: error: use of deleted function 'octave::symbol_table::symbol_table()'
> 283 | octave_value ov=octave::symbol_table().global_varval(string(baseName));
> | ^
> In file included from /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/octave-config.h:99,
> from /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/parse.h:29,
> from Octave.C:18:
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/symtab.h:63:39: note: declared here
> 63 | OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE (symbol_table)
> | ^~~~~~~~~~~~
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/oct-conf-post-public.h:354:3: note: in definition of macro 'OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE'
> 354 | X () = delete; \
> | ^
> Octave.C:284:34: error: use of deleted function 'octave::symbol_table::symbol_table()'
> 284 | octave::symbol_table().global_assign (string(baseName), setGlobalSubVariable(varNames, m, 0, ov));
> | ^
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/symtab.h:63:39: note: declared here
> 63 | OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE (symbol_table)
> | ^~~~~~~~~~~~
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/oct-conf-post-public.h:354:3: note: in definition of macro 'OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE'
> 354 | X () = delete; \
> | ^
> Octave.C:286:34: error: use of deleted function 'octave::symbol_table::symbol_table()'
> 286 | octave::symbol_table().global_assign (string(baseName), m);
> | ^
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/symtab.h:63:39: note: declared here
> 63 | OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE (symbol_table)
> | ^~~~~~~~~~~~
> /home/fabrice/buildroot/output/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/octave-9.2.0/octave/oct-conf-post-public.h:354:3: note: in definition of macro 'OCTAVE_DISABLE_CONSTRUCT_COPY_MOVE'
> 354 | X () = delete; \
> | ^
> Octave.C: In member function 'octave_map Octave::setGlobalSubVariable(const std::vector<std::__cxx11::basic_string<char> >&, const Matrix&, int, octave_value&)':
> Octave.C:302:38: error: 'class string_vector' has no member named 'lookup'
> 302 | whichIdx=base.map_keys().lookup(varNames[index+1]); // map_keys returns a string_vector
> | ^~~~~~
>
> Fixes: fab48302865e5c0c98d91b696bc90e75e38189bb
> - http://autobuild.buildroot.org/results/9cfc420a4e41503635792472176583a8f81bb2a3
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/gtkiostream/gtkiostream.mk | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-22 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 8:21 [Buildroot] [PATCH 1/1] package/gtkiostream: disable octave Fabrice Fontaine
2024-07-22 12:10 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722141024.3be863b1@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo.compagnucci@gmail.com \
--cc=flatmax@flatmax.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox