From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2,1/1] package/gnutls: disable tpm2-tss
Date: Mon, 22 Jul 2024 14:30:00 +0200 [thread overview]
Message-ID: <20240722143000.42dfb7c0@windsurf> (raw)
In-Reply-To: <20240721165717.1996106-1-fontaine.fabrice@gmail.com>
On Sun, 21 Jul 2024 18:57:17 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Disable tpm2-tss to avoid the following circular dependency if
> BR2_PACKAGE_TPM2_TSS_FAPI is selected:
> tpm2-tss -> libcurl -> gnutls -> tmp2-tss
> resulting in the following build failure of libcurl or rtmpdump since
> commit caff4179a4481233257f5f475ca57ce9061af900:
>
> configure: error: TLS not detected, you will not be able to use HTTPS, FTPS, NTLM and more.
> Use --with-openssl, --with-gnutls, --with-wolfssl, --with-mbedtls, --with-schannel, --with-secure-transport, --with-amissl, --with-bearssl or --with-rustls to address this.
>
> [...]
>
> In file included from rtmp.c:32:
> rtmp_sys.h:110:10: fatal error: gnutls/gnutls.h: No such file or directory
> 110 | #include <gnutls/gnutls.h>
> | ^~~~~~~~~~~~~~~~~
>
> Fixes: caff4179a4481233257f5f475ca57ce9061af900
> - http://autobuild.buildroot.org/results/72e1843de650c9ed4795f1141e9fd485b71a14c3
> - http://autobuild.buildroot.org/results/918f0f7efa810b17f6d2266a890bf0150cbed146
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Baruch Siach):
> - Add --without-tpm2
I have applied. However, I think it would be nice to add a comment in
the .mk file to explain why we are passing --without-tpm2, to avoid
having someone else re-introduce this optional dependency. Perhaps you
could send a follow-up patch adding that?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-22 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 16:57 [Buildroot] [PATCH v2,1/1] package/gnutls: disable tpm2-tss Fabrice Fontaine
2024-07-22 12:30 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722143000.42dfb7c0@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox