From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/faifa: bump to latest git commit
Date: Mon, 22 Jul 2024 18:13:01 +0200 [thread overview]
Message-ID: <20240722181301.16986c2c@windsurf> (raw)
In-Reply-To: <20240722155909.53198-1-fontaine.fabrice@gmail.com>
On Mon, 22 Jul 2024 17:59:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> - Drop patches (already in version)
> - libevent is mandatory since
> https://github.com/ffainelli/faifa/commit/d2339c2a7680e7c87555650e19123e27e1f12031
> - This bump will fix the following build failure with gcc >= 14:
>
> hpav_cfg.c: In function 'pushbutton_request':
> hpav_cfg.c:256:37: error: passing argument 2 of 'send_vendor_pkt' makes pointer from integer without a cast [-Wint-conversion]
> 256 | return send_vendor_pkt(ctx, mac, HPAV_MMTYPE_MS_PB_ENC,
> | ^~~
> | |
> | uint8_t {aka unsigned char}
> hpav_cfg.c:123:64: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'uint8_t' {aka 'unsigned char'}
> 123 | static int send_vendor_pkt(struct context *ctx, const uint8_t *to,
> | ~~~~~~~~~~~~~~~^~
> hpav_cfg.c: In function 'main':
> hpav_cfg.c:406:48: error: passing argument 2 of 'pushbutton_request' makes integer from pointer without a cast [-Wint-conversion]
> 406 | ret = pushbutton_request(&ctx, mac);
> | ^~~
> | |
> | uint8_t * {aka unsigned char *}
> hpav_cfg.c:254:60: note: expected 'uint8_t' {aka 'unsigned char'} but argument is of type 'uint8_t *' {aka 'unsigned char *'}
> 254 | static int pushbutton_request(struct context *ctx, uint8_t mac)
> | ~~~~~~~~^~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/5a65337366e52c6234d8d154b7e9a0296e02f1dd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> .checkpackageignore | 3 --
> ...y-include-endian.h-for-BYTE_ORDER-ma.patch | 32 -------------------
> ...t-include-linux-if_ether.h-for-musl-.patch | 32 -------------------
> ...-fix-asbolute-symlink-of-libfaifa.so.patch | 32 -------------------
> package/faifa/Config.in | 1 +
> package/faifa/faifa.hash | 2 +-
> package/faifa/faifa.mk | 6 ++--
> 7 files changed, 5 insertions(+), 103 deletions(-)
> delete mode 100644 package/faifa/0001-sha2.c-explicitly-include-endian.h-for-BYTE_ORDER-ma.patch
> delete mode 100644 package/faifa/0002-hpav_cfg.c-do-not-include-linux-if_ether.h-for-musl-.patch
> delete mode 100644 package/faifa/0003-Makefile.in-fix-asbolute-symlink-of-libfaifa.so.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-22 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 15:59 [Buildroot] [PATCH 1/1] package/faifa: bump to latest git commit Fabrice Fontaine
2024-07-22 16:13 ` Thomas Petazzoni via buildroot [this message]
2024-08-31 11:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722181301.16986c2c@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox