Re: [Buildroot] [PATCH 1/1] package/zfs: fix uClibc support

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>
Cc: Alexander Mukhin <alexander.i.mukhin@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/zfs: fix uClibc support
Date: Mon, 22 Jul 2024 18:23:12 +0200	[thread overview]
Message-ID: <20240722182312.1500234b@windsurf> (raw)
In-Reply-To: <20240722142141.2105929-2-salvador.joseluis@gmail.com>

Hello José,

On Mon, 22 Jul 2024 16:21:42 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> This update addresses the issue of uClibc support by skipping ZFS tests
> that require SEEK_DATA support.
> 
> This is a work-in-progress patch while we wait for an upstream fix.
> Current upstream efforts can be followed here:
> https://github.com/openzfs/zfs/pull/16169
> 
> Context:
> - OpenZFS includes a test for a bug that occurs when copying a large
>   number of PUNCHED files.
> - OpenZFS has backported this test to v2.2.x.
> - uClibc does not support SEEK_DATA and SEEK_HOLE.
> - The ZFS test `cp_stress` can not be compiled using uClibc.
> 
> This commit fix:
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/7391793226
> 
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Thanks for coming up with the patch! See below some comments.

> + config/user-unistd.m4                  | 24 ++++++++++++++++++++++++
> + config/user.m4                         |  1 +
> + config/zfs-build.m4                    |  1 +

Since this patch touches the m4 machinery, we need ZFS_AUTORECONF = YES
in the .mk file. Turns out it is already there... but for the wrong
reason:

# 0001-config-user-check-for-aio.h.patch
ZFS_AUTORECONF = YES

Indeed, this patch 0001-config-user-check-for-aio.h.patch is no longer
there.

Could you as part of this patch fix this up?

> diff --git a/package/zfs/zfs.hash b/package/zfs/zfs.hash
> index 9c8d4cec85..bef95063f9 100644
> --- a/package/zfs/zfs.hash
> +++ b/package/zfs/zfs.hash
> @@ -4,3 +4,5 @@ sha256  9790905f7683d41759418e1ef3432828c31116654ff040e91356ff1c21c31ec0  zfs-2.
>  # Hash for license files:
>  sha256  1ffb70c33c4f79f04e947facc5c7851f289609256aacb47fc115f700427d9520  LICENSE
>  sha256  f125a37c829705eff3e6f77a9f6c58fd71060f84ab54180b98fafdf94a2021eb  COPYRIGHT
> +
> +sha256  71e605df37abf8c48b7c103e6dec7538b5d06fc91416c77c50525d021b9b91b0  0001-tests-cp_files-ignore-if-SEEK_DATA-is-not-defined.patch

No need to push the hash of the patch in the hash file. The hash file
is to document hashes of stuff downloaded by Buildroot. Here the patch
is provided *by* Buildroot, so no hash checking is needed for it.

Could you send a v2 to address those two small comments?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot