From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-meson: support building both libraries
Date: Mon, 22 Jul 2024 18:23:47 +0200 [thread overview]
Message-ID: <20240722182347.1bac99cb@windsurf> (raw)
In-Reply-To: <20240722131750.519333-1-fontaine.fabrice@gmail.com>
On Mon, 22 Jul 2024 15:17:50 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> meson supports building both libraries (i.e. static and shared).
> This will avoid the following build failure with flashrom and
> BR2_SHARED_STATIC_LIBS raised since bump to version 1.4.0-rc2 in commit
> 8637884057ddc3c1aeb9f0dd285fc6fcf378c26b:
>
> ../output-1/build/flashrom-1.4.0-rc2/meson.build:18:2: ERROR: Problem encountered:
> Cannot build cli_classic with shared libflashrom. Use \'-Dclassic_cli=disabled\' to disable the cli,
> or use \'--default-library=both\' to also build the classic_cli
>
> Fixes: 8637884057ddc3c1aeb9f0dd285fc6fcf378c26b
> - http://autobuild.buildroot.org/results/6d484857ff1674bf81986505827e54f3f1b9aaec
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/pkg-meson.mk | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Applied to master, thanks. I'm guessing this could cause a bit of
breakage, but let's see how much :-)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-22 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 13:17 [Buildroot] [PATCH 1/1] package/pkg-meson: support building both libraries Fabrice Fontaine
2024-07-22 16:23 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722182347.1bac99cb@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox