From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/coreutils: fix glibc build with gcc >= 14
Date: Tue, 23 Jul 2024 10:49:52 +0200 [thread overview]
Message-ID: <20240723104952.6340bad2@windsurf> (raw)
In-Reply-To: <20240722220922.590401-1-fontaine.fabrice@gmail.com>
On Tue, 23 Jul 2024 00:09:22 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> ac_cv_func_strerror_r_char_p is hardcoded to no since commit
> 74b9bf9945921a7b0504b4b546a4bc26f2adcc45 back in 2005 however strerror_r
> only returns an int with musl. With glibc or uclibc, strerror_r returns
> a char* or an int depending on _GNU_SOURCE value resulting in the
> following build failure with gcc >= 14:
>
> strerror_r.c: In function 'rpl_strerror_r':
> strerror_r.c:207:9: error: assignment to 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
> 207 | ret = strerror_r (errnum, buf, buflen);
> | ^
>
> To fix this build failure, don't hardcode ac_cv_func_strerror_r_char_p
> to let coreutils pick the correct value
>
> Fixes:
> - http://autobuild.buildroot.org/results/8bc649ca5490b0c29c90383edfa2e693f154ebc4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/coreutils/coreutils.mk | 1 -
> 1 file changed, 1 deletion(-)
Applied to master, thanks. But then it means that indeed your commit
6f34e68217264fb62c48ce28c48bf759b30fef0e fixing the same issue in
package/apr could be improved to avoid using an AC_TRY_RUN(), and
therefore not need an autoconf cache variable value passed by apr.mk.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-23 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 22:09 [Buildroot] [PATCH 1/1] package/coreutils: fix glibc build with gcc >= 14 Fabrice Fontaine
2024-07-23 8:49 ` Thomas Petazzoni via buildroot [this message]
2024-08-31 16:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723104952.6340bad2@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox