Re: [Buildroot] [PATCH v3, 1/1] package/cwiid: fix build with gcc >= 14

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fabrice,

Thanks for the new iteration.

On Tue, 23 Jul 2024 11:33:12 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> new file mode 100644
> index 0000000000..ba8121802b
> --- /dev/null
> +++ b/package/cwiid/0003-wminput-plugins-led-led.c-fix-build-with-gcc-14.patch
> @@ -0,0 +1,37 @@
> +From 10106fdb4cc833faa3c2fcb980d0a4eb121fe19d Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Tue, 23 Jul 2024 10:31:32 +0200
> +Subject: [PATCH] wminput/plugins/led/led.c: fix build with gcc >= 14
> +
> +Fix the following build failure with gcc >= 14:
> +
> +led.c: In function 'wmplugin_exec':
> +led.c:86:42: error: assignment to 'struct cwiid_btn_message *' from incompatible pointer type 'struct cwiid_btn_mesg *' [-Wincompatible-pointer-types]
> +   86 |                                 btn_mesg = &mesg[i].btn_mesg;
> +      |                                          ^
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/a3bde74ff2137d088f4261e62930859bfe460cb9
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Upstream: https://github.com/abstrakraft/cwiid/pull/47

But is it the right fix this time? (I believe so, but your commit log
doesn't explain why it's the right fix, and what was wrong before).

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot