From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ebtables: fix build with gcc >= 14
Date: Wed, 24 Jul 2024 18:29:28 +0200 [thread overview]
Message-ID: <20240724182928.3c9c1877@windsurf> (raw)
In-Reply-To: <20240724071904.1397662-1-fontaine.fabrice@gmail.com>
Hello,
Another short comment.
On Wed, 24 Jul 2024 09:19:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> diff --git a/package/ebtables/Config.in b/package/ebtables/Config.in
> index 703e55a3c3..ea06b0d8b5 100644
> --- a/package/ebtables/Config.in
> +++ b/package/ebtables/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_EBTABLES
> bool "ebtables"
> depends on BR2_USE_MMU # fork()
> + depends on !BR2_KERNEL_64_USERLAND_32
As this is a super unusual dependency, we clearly want to have a
comment above it (not a Config.in comment, a source comment) that
explains why we have this strange dependency.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-24 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 7:19 [Buildroot] [PATCH 1/1] package/ebtables: fix build with gcc >= 14 Fabrice Fontaine
2024-07-24 16:28 ` Thomas Petazzoni via buildroot
2024-08-02 17:20 ` Thomas Petazzoni via buildroot
2024-07-24 16:29 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240724182928.3c9c1877@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox