Re: [Buildroot] [PATCH 1/2] Revert "Create a .gitignore file in the CANONICAL_O directory"

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 24 Jul 2024 21:23:20 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> The packages 'python-jsonschema-specifications', 'pydantic-core', and
> likely other packages based on Python maturin silently stopped
> installing files to the host and target directories after commit
> a14c862c08.
> 
> A similar issue was reported by the Conda project[1]. It seems some
> build tools scan for gitignore files to decide what files to build
> and install.
> 
> I attempted various combinations of gitignore patterns including
> mimicking the Conda project's gitignore[2], but the only thing that has
> worked reliably is the original `/output` ignore in the root Buildroot
> directory.
> 
> This reverts commit a14c862c08865e053d5fce90a0d0323b8f9e4bc0.
> 
> [1] https://github.com/PyO3/maturin/issues/1911
> [2] https://github.com/conda-forge/conda-smithy/blob/main/conda_smithy/feedstock_content/.gitignore
> Reported-by: Bryan Brattlof <bb@ti.com>
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> ---
>  .gitignore | 1 +
>  Makefile   | 3 ---
>  2 files changed, 1 insertion(+), 3 deletions(-)

Thanks, both applied. Of course, I'm not a huge fan of PATCH 2/2,
because there's really no reason for output folders to be called
"output<something>", but until we can create the .gitignore file in the
output folder itself, I guess this is a reasonable workaround to allow
people to create multiple output directories that are ignored.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot