From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Danomi Manchego <danomimanchego123@gmail.com>
Cc: "Stefan Sørensen" <stefan.sorensen@spectralink.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] libpwquality: fix PAM module path
Date: Fri, 26 Jul 2024 14:12:48 +0200 [thread overview]
Message-ID: <20240726141248.41369067@windsurf> (raw)
In-Reply-To: <20240726094603.10333-1-danomimanchego123@gmail.com>
On Fri, 26 Jul 2024 05:46:03 -0400
Danomi Manchego <danomimanchego123@gmail.com> wrote:
> The libpwquality package provides the pam_pwquality PAM module - the
> replacement for pam_cracklib that was dropped from linux-pam back in
> version 1.5.0. However, it currently installs it to the wrong place,
> so passwd and friends fail to find it. This commit sets the security
> directory path to /lib/security to match the corresponding setting in
> linux-pam.mk.
>
> Note that libpwquality has *always* installed pam_pwquality in the wrong
> place, since version 1.3.0 was added to buildroot in 2017 in commit
> 462040443ca943694fc59ec8380c82f8bf9aaddc. However, back then, linux-pam
> version 1.3.0 still provided pam_cracklib for advanced password checking.
> Linux-pam deprecated pam_cracklib in 1.4.0 but still built it for us when
> linux-pam.mk set --enable-cracklib. Linux-PAM deleted pam_cracklib
> altogether in 1.5.0, so it was not until our update to linux-pam-1.5.1
> in commit 276f1e0a896698abec85500a86686bf72c79eb91 that pam_cracklib
> became unavailable. After that point, pam_pwquality was the only
> alternative for PAM-based password checking.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
>
> ---
Wow, *that* is an amazing commit log with all the details about the
problem. I think we could link to your commit message as a golden
example of the level of explanation we would like to have. Thanks a lot
for coming up with this v2, which I have of course applied!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-26 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 9:46 [Buildroot] [PATCH v2 1/1] libpwquality: fix PAM module path Danomi Manchego
2024-07-26 12:12 ` Thomas Petazzoni via buildroot [this message]
2024-09-01 8:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726141248.41369067@windsurf \
--to=buildroot@buildroot.org \
--cc=danomimanchego123@gmail.com \
--cc=stefan.sorensen@spectralink.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox