Re: [Buildroot] [PATCH v2 1/1] package/espflash: add udev dependency

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for the new iteration, which I have applied. Just one minor nit,
see below!

On Mon, 29 Jul 2024 21:32:43 +0200
Torben Voltmer <mail@t-voltmer.net> wrote:

> Adding the dependency on udev, since espflash links libudev
> (via the libudev-sys crate).
> 
> Fixes: http://autobuild.buildroot.net/results/c61b6ed4b6fb4d18d503ac37add200f5e6ae3706
> 
> ---
> Changes v1 -> v2:
>   - Added missing dependency in espflash.mk
>   - Added missing depends on in Config.in
>   - Verified that the updated patch fixes at least one autobuild failure
> 
> Signed-off-by: Torben Voltmer <mail@t-voltmer.net>

The Signed-off-by: line should be *before* the --- sign. Indeed, when
git applies a patch, it drops from the commit log everything which is
after the --- sign. This is why your changelog (Changes v1 -> v2) is at
the right: we don't want this changelog to be part of the final commit
message. However, we do want the Signed-off-by to be part of the commit
message, so it should be before the --- sign.

I fixed that up when applying. Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot