Re: [Buildroot] [PATCH 1/3] boot/arm-trusted-firmware: update source to the new mirror

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bryan Brattlof via buildroot <buildroot@buildroot.org>
Cc: "Vincent Stehlé" <vincent.stehle@arm.com>,
	"Marleen Vos" <marleen.vos@mind.be>, "Bryan Brattlof" <bb@ti.com>,
	"Sergey Matyukevich" <geomatsi@gmail.com>,
	"Romain Naour" <romain.naour@smile.fr>,
	"Xuanhao Shi" <X15000177@gmail.com>,
	"Dario Binacchi" <dario.binacchi@amarulasolutions.com>,
	"Ariel D'Alessandro" <ariel@vanguardiasur.com.ar>,
	"Romain Naour" <romain.naour@gmail.com>,
	"Michael Trimarchi" <michael@amarulasolutions.com>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Anand Gadiyar" <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH 1/3] boot/arm-trusted-firmware: update source to the new mirror
Date: Sat, 3 Aug 2024 23:59:43 +0200	[thread overview]
Message-ID: <20240803235943.226e6d14@windsurf> (raw)
In-Reply-To: <20240722-tfa-src-update-v1-1-e68bba62f146@ti.com>

Hello Bryan,

On Mon, 22 Jul 2024 14:17:37 -0500
Bryan Brattlof via buildroot <buildroot@buildroot.org> wrote:

> Tags are no longer being pused to the old ARM-softwre
> mirror. Let's move to the new mirror at TrustedFirmware-A which
> continues to publish newer tags
> 
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
>  .../fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash   | 2 +-
>  .../patches/arm-trusted-firmware/arm-trusted-firmware.hash            | 2 +-
>  .../beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +-
>  .../patches/arm-trusted-firmware/arm-trusted-firmware.hash            | 2 +-
>  .../patches/arm-trusted-firmware/arm-trusted-firmware.hash            | 2 +-
>  board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash     | 2 +-
>  .../stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +-
>  .../am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash  | 2 +-
>  .../am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash   | 2 +-
>  .../am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash   | 2 +-
>  boot/arm-trusted-firmware/arm-trusted-firmware.hash                   | 4 ++--
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk                     | 2 +-
>  12 files changed, 13 insertions(+), 13 deletions(-)

I have applied locally, but not yet pushed. My concern is that it's
really annoying that it breaks hashes for all previous versions of
TF-A. This means that all people having existing defconfigs (not the
one in Buildroot) that use
BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE will see their
build fail now. And even for those using the defconfigs in Buildroot,
they will see a hash mismatch message and a redownload.

But I don't really see any other way around that. The issue is
basically that we are not fetching real tarballs, but auto-generated
ones, which are different when fetched from one repo or another.

Should we instead switch to fetching via Git all the time? Should we
switch to using the official Git repo, instead of a Github mirror?

As you can see, I am not 100% sure about this change, even though we
obviously need to change something to be able to use the newer versions
of TF-A...

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot