Re: [Buildroot] [PATCH v2 1/1] package/spdlog: add menuconfig option to select formatter

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Joachim Wiberg <troglobit@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/spdlog: add menuconfig option to select formatter
Date: Sun, 4 Aug 2024 22:22:32 +0200	[thread overview]
Message-ID: <20240804222232.56c2130a@windsurf> (raw)
In-Reply-To: <20240804094647.876936-1-troglobit@gmail.com>

Hello Joachim,

On Sun,  4 Aug 2024 11:46:47 +0200
Joachim Wiberg <troglobit@gmail.com> wrote:

> Add an option menu to select the spdlog formatter: external fmt library,
> external using headers-only, C++20 std:format, or the bundled (version
> matched) fmt library, which each release of spdlog is tested against.
> 
> The formatters are mutually exclusive (see the CMakeLists.txt[1] file),
> selecting the 'internal' option disables all the other options in the
> .mk file, thus "enabling" the bundled formatter.
> 
> For backwards compatibility, the Buildroot default remains using the
> external fmt library.
> 
> [1]: https://github.com/gabime/spdlog/blob/5ebfc92/CMakeLists.txt#L95-L105

Could you provide some details on why we would want to support
different formatters?

In your reply to Baruch you said you wanted to package Rousette, which
requires the bundled fmt. How is the bundled fmt different from the
external one?

Also using a choice...endchoice here will not make it easy to package
Rousette, because you can't "select" an option of a choice...endchoice,
so the Rousette package will not be able to select
BR2_PACKAGE_SPDLOG_FMT_INTERNAL.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot