From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Wilfred Mallawa via buildroot <buildroot@buildroot.org>
Cc: Wilfred Mallawa <wilfred.mallawa@wdc.com>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [Buildroot] [PATCH v3 1/1] package/libspdm: bump version to 3.4.0
Date: Sun, 4 Aug 2024 23:15:09 +0200 [thread overview]
Message-ID: <20240804231509.4a0f8075@windsurf> (raw)
In-Reply-To: <20240719064402.3105153-2-wilfred.mallawa@wdc.com>
Hello Wilfred,
On Fri, 19 Jul 2024 16:44:03 +1000
Wilfred Mallawa via buildroot <buildroot@buildroot.org> wrote:
> From: Wilfred Mallawa via buildroot <buildroot@buildroot.org>
>
> `libspdm 3.3.0` and later support the SPDM event capability, however
> this patch disables support for EVENT_CAP as it is optional,
> and requires additional functionality implemented at link time.
>
> `libspdm 3.4.0` also introduces SPDM1.3 measurement extention log (MEL).
> Leave this off by default for the same reason as above.
>
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Thanks for this new iteration! Some comments/questions below.
> -LIBSPDM_VERSION = 3.2.0
> +LIBSPDM_VERSION = 3.4.0
> LIBSPDM_SITE = $(call github,DMTF,libspdm,$(LIBSPDM_VERSION))
> LIBSPDM_LICENSE = BSD-3-Clause
> LIBSPDM_LICENSE_FILES = LICENSE.md
> @@ -27,7 +27,9 @@ LIBSPDM_CONF_OPTS = \
> -DCOMPILED_LIBSSL_PATH=/usr/lib/ \
> -DDISABLE_TESTS=1 \
> -DDISABLE_EDDSA=1 \
> - -DLINK_FLAGS=$(STAGING_DIR)
> + -DLINK_FLAGS=$(STAGING_DIR) \
> + -DCMAKE_C_FLAGS="-DLIBSPDM_ENABLE_CAPABILITY_EVENT_CAP=0 \
> + -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP=0" ..
What is this ".." at the end of the line ?
Also, the way you're passing CFLAGS completely drops our
$(TARGET_CFLAGS). So instead you should do this:
LIBSPDM_CFLAGS = \
$(TARGET_CFLAGS) \
-DLIBSPDM_ENABLE_CAPABILITY_EVENT_CAP=0 \
-DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP=0
and in the LIBSPDM_CONF_OPTS:
-DCMAKE_C_FLAGS="$(LIBSPDM_CFLAGS)"
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-04 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 6:44 [Buildroot] [PATCH v3 1/1] package/libspdm: bump version to 3.4.0 Wilfred Mallawa via buildroot
2024-07-19 8:08 ` Alistair Francis
2024-08-04 21:15 ` Thomas Petazzoni via buildroot [this message]
2024-08-05 2:01 ` Wilfred Mallawa via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804231509.4a0f8075@windsurf \
--to=buildroot@buildroot.org \
--cc=alistair@alistair23.me \
--cc=thomas.petazzoni@bootlin.com \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox