From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nginx: fix sparc compile
Date: Mon, 5 Aug 2024 09:31:06 +0200 [thread overview]
Message-ID: <20240805093106.20d6716d@windsurf> (raw)
In-Reply-To: <ZrB+QUlNw6G1wbV4@waldemar-brodkorb.de>
On Mon, 5 Aug 2024 09:24:49 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> The minimal reproducer is:
> BR2_sparc=y
> BR2_PACKAGE_NGINX=y
Weird, I didn't reproduce it with the Bootlin SPARC toolchain.
> For sparc only libatomic_ops is selected via
> package/nginx/Config.in. So I think the build issue is unique to
> sparcv8/leon.
Correct, but in the .mk file we have:
ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
NGINX_DEPENDENCIES += libatomic_ops
NGINX_CONF_OPTS += --with-libatomic
NGINX_CONF_ENV += ngx_force_have_libatomic=yes
ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)
NGINX_CFLAGS += "-DAO_NO_SPARC_V9"
endif
else
NGINX_CONF_ENV += ngx_force_have_libatomic=no
endif
and BR2_PACKAGE_LIBATOMIC_OPS can very well be enabled on non-SPARC
architectures. Yes nginx only forces BR2_PACKAGE_LIBATOMIC_OPS on
Sparc, but nothing prevents another package (or even the user) to
enable BR2_PACKAGE_LIBATOMIC_OPS on non-Sparc architectures.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-05 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 11:20 [Buildroot] [PATCH] package/nginx: fix sparc compile Waldemar Brodkorb
2024-08-04 21:12 ` Thomas Petazzoni via buildroot
2024-08-05 7:24 ` Waldemar Brodkorb
2024-08-05 7:31 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805093106.20d6716d@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox