From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH] package/nethogs: new package
Date: Mon, 5 Aug 2024 13:34:13 +0200 [thread overview]
Message-ID: <20240805133413.6df83574@windsurf> (raw)
In-Reply-To: <20240213120452.2465425-1-buildroot@bubu1.eu>
Hello Marcus,
On Tue, 13 Feb 2024 13:04:51 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
Thanks for the patch, which I have applied, after making a few changes.
See below.
> ---
> package/Config.in | 1 +
> package/nethogs/Config.in | 10 ++++++++++
> package/nethogs/nethogs.hash | 3 +++
> package/nethogs/nethogs.mk | 21 +++++++++++++++++++++
> 4 files changed, 35 insertions(+)
Entry in the DEVELOPERS file was missing.
> diff --git a/package/Config.in b/package/Config.in
> index bf0fe078b9..2d352dd8cc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2476,6 +2476,7 @@ endif
> source "package/ndisc6/Config.in"
> source "package/net-tools/Config.in"
> source "package/netatalk/Config.in"
> + source "package/nethogs/Config.in"
> source "package/netcalc/Config.in"
> source "package/netcat/Config.in"
> source "package/netcat-openbsd/Config.in"
As you noted in your replied, alphabetic ordering was not correct here.
> +NETHOGS_VERSION = 0.8.7
> +NETHOGS_SITE = $(call github,raboof,nethogs,v$(NETHOGS_VERSION))
> +NETHOGS_LICENSE = GPL-2.0
License is GPL-2.0+ (they use the "or later")
> +NETHOGS_LICENSE_FILES = COPYING
> +NETHOGS_DEPENDENCIES = libpcap ncurses
> +
> +define NETHOGS_BUILD_CMDS
> + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) nethogs
> +endef
> +
> +define NETHOGS_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/src/nethogs $(TARGET_DIR)/usr/sbin
$(TARGET_DIR)/usr/sbin should have been $(TARGET_DIR)/usr/sbin/nethogs,
to avoid having 'nethogs' installed as a file called 'sbin' in
$(TARGET_DIR)/usr if by lack of luck $(TARGET_DIR)/usr/sbin doesn't
already exist as a directory.
Thanks a lot for this contribution!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-05 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 12:04 [Buildroot] [PATCH] package/nethogs: new package Marcus Hoffmann via buildroot
2024-02-13 12:09 ` Marcus Hoffmann via buildroot
2024-08-05 11:34 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805133413.6df83574@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@bubu1.eu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox