Re: [Buildroot] [PATCH 1/1] package/atop: bump to version 2.10.0 - Added a new dependency - libglib2 - Remove 0001-atop.h-include-time.h.patch. It was applied upstream (https://github.com/Atoptool/atop/commit/03c5c4dd29bc7590baccb55a36d61e7f4b39c1fe).

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 11 Feb 2024 19:47:57 -0800
Kadambini Nema <kadambini.nema@gmail.com> wrote:

> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
> ---
>  package/atop/0001-atop.h-include-time.h.patch | 41 -------------------
>  package/atop/Config.in                        |  1 +
>  package/atop/atop.hash                        |  2 +-
>  package/atop/atop.mk                          | 10 +++--
>  4 files changed, 8 insertions(+), 46 deletions(-)
>  delete mode 100644 package/atop/0001-atop.h-include-time.h.patch

Thanks, I've applied.

There was an issue in your commit log: the whole message was on one
single line, while it should have been split. A proper commit message
had a title (reasonably short), then an empty new line, then one or
more paragraphs of additional explanation. Check all other commit logs
in Buildroot.

Another issue was that you forgot the host-pkgconf dependency, which is
needed as atop's Makefile uses pkg-config to find glib.

Finally, the duplication of CFLAGS/LDFLAGS from atop's Makefile into
atop.mk wasn't really nice. So instead I cooked a patch, submitted
upstream, which allows atop.mk to pass additional CFLAGS/LDFLAGS
without overriding them.

You can have a look at the final commit at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/beb54d8126e7b0fd2e1090061aa96e6487c4b697

Thanks a lot for your contribution, and sorry for the huge amount of
time it took us to look into your patch.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot