From: Markus Mayer via buildroot <buildroot@buildroot.org>
To: Buildroot Mailing List <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Markus Mayer <mmayer@broadcom.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: [Buildroot] [PATCH] package/xz: avoid cicular dependency on autoconf for host builds
Date: Mon, 5 Aug 2024 20:06:59 -0700 [thread overview]
Message-ID: <20240806030701.618378-1-mmayer@broadcom.com> (raw)
autoconf has an implicit dependency on HOST_XZ due to extracting a
tar.xz archive. By enabling XZ_AUTORECONF we create a reverse dependency
for xz on autoconf. This is fine for target builds, but it won't work
for host builds, as the two packages now depend on each other.
This problem only occurs if host tools are being built by Buildroot. If
the build relies on host tools provided by the distro, there is no
circular dependency problem.
Fixes:
4703a7ae9176 package/xz: fix musl static build
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
package/xz/xz.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/xz/xz.mk b/package/xz/xz.mk
index 9fb93ff4d6b5..028cd5bdf525 100644
--- a/package/xz/xz.mk
+++ b/package/xz/xz.mk
@@ -68,5 +68,12 @@ HOST_XZ_CONF_ENV = \
CC="$(HOSTCC_NOCCACHE)" \
CXX="$(HOSTCXX_NOCCACHE)"
+# We need to prevent XZ_AUTORECONF for host builds or we end up with a circular
+# dependency. Since the autoconf build needs to extract a tar.xz archive,
+# autoconf has an implicit dependency on HOST_XZ. By enabling XZ_AUTORECONF we
+# also make host-xz depend on autoconf, which we can't do. It is also not
+# necessary.
+HOST_XZ_AUTORECONF = NO
+
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2024-08-06 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 3:06 Markus Mayer via buildroot [this message]
2024-08-06 15:03 ` [Buildroot] [PATCH] package/xz: avoid cicular dependency on autoconf for host builds Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806030701.618378-1-mmayer@broadcom.com \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=mmayer@broadcom.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox