From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openconnect: Fix openssl support
Date: Tue, 6 Aug 2024 17:03:36 +0200 [thread overview]
Message-ID: <20240806170336.0dd5305c@windsurf> (raw)
In-Reply-To: <20240806053623.776588-1-bernd@kuhls.net>
On Tue, 6 Aug 2024 07:36:23 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Enable needed OpenSSL options even when GnuTLS is enabled by respecting
> BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL=y set by other packages.
>
> Fixes:
> http://autobuild.buildroot.net/results/f53/f535a63b80f2efe59709d5d9b59bc27ba66d2c26/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/openconnect/Config.in | 4 ++--
> package/openconnect/openconnect.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/openconnect/Config.in b/package/openconnect/Config.in
> index cacf617fb9..6bc747bc2d 100644
> --- a/package/openconnect/Config.in
> +++ b/package/openconnect/Config.in
> @@ -4,8 +4,8 @@ config BR2_PACKAGE_OPENCONNECT
> select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
> # configure: error: LibreSSL does not support Cisco DTLS.
> select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL if !BR2_PACKAGE_GNUTLS
> - select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if !BR2_PACKAGE_GNUTLS
> - select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if !BR2_PACKAGE_GNUTLS
> + select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
> + select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
Using BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL seemed not really
appropriate here. Other packages that have to do this use:
select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
so I changed to this instead.
> -ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +ifeq ($(BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL),y)
This change was not needed, so I dropped it.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-06 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 5:36 [Buildroot] [PATCH 1/1] package/openconnect: Fix openssl support Bernd Kuhls
2024-08-06 15:03 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806170336.0dd5305c@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox