From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BBCAC52D70 for ; Tue, 6 Aug 2024 17:43:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D0FA74042F; Tue, 6 Aug 2024 17:43:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CpwlKXJ73UoW; Tue, 6 Aug 2024 17:43:48 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 43D6E403FB Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 43D6E403FB; Tue, 6 Aug 2024 17:43:48 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9984D1BF3BF for ; Tue, 6 Aug 2024 17:43:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 85F8860842 for ; Tue, 6 Aug 2024 17:43:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 1fSv2Gh3eiVO for ; Tue, 6 Aug 2024 17:43:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4b98:dc4:8::225; helo=relay5-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org DFF696082F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DFF696082F Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by smtp3.osuosl.org (Postfix) with ESMTPS id DFF696082F for ; Tue, 6 Aug 2024 17:43:43 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 287431C0002; Tue, 6 Aug 2024 17:43:41 +0000 (UTC) Date: Tue, 6 Aug 2024 19:43:40 +0200 To: Julien Olivain Message-ID: <20240806194340.2e542192@windsurf> In-Reply-To: <20240207225100.1320837-1-ju.o@free.fr> References: <20240207225100.1320837-1-ju.o@free.fr> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1722966221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QNq6MEmU8ruH1ksnqya6It5or/A8CzwNnYppE/Ww5E=; b=HvLQo/Y0u6ktYGDMeW2qpwSdpsG73uQsMx6nW10PuUdMQk2nbxXUEN4Q+IOgUpntDEgvQV F4raRr0ym6v6WyC2go8vJMEhRDwtt9CTSXf8hwImilgRSZPzNfBZ0hVnG35RaVbJXMuBGJ QrIhSA4tnjbMR1wxez3H8Vap6GWbTEAtU29esZdbWZe4hW78dzREBwM5VSnWz8l780vnEW /RbciBRemDYqZejObcUDQuRJJ/DQ9Vn5DbVG4nEFiz2NBf0aRyDWCmh6LVf9pns6Rfp5Qf 2y+yw4yVjobEqV1uBDPzT5xT+wetff1pnqPYZmOZk2N3hOaNzZh7XVcGGLyUOw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=HvLQo/Y0 Subject: Re: [Buildroot] [PATCH v2 1/1] package/swipl: new package X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello Julien, On Wed, 7 Feb 2024 23:51:00 +0100 Julien Olivain wrote: > SWI-Prolog offers a comprehensive free Prolog environment. Since its > start in 1987, SWI-Prolog development has been driven by the needs of > real world applications. SWI-Prolog is widely used in research and > education as well as commercial applications. > > Signed-off-by: Julien Olivain I've finally applied, with some minor changes. > diff --git a/package/Config.in b/package/Config.in > index 91a6f1de00..b1a9d74af1 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1443,6 +1443,7 @@ endmenu > endif > source "package/quickjs/Config.in" > source "package/ruby/Config.in" > + source "package/swipl/Config.in" > source "package/tcl/Config.in" > if BR2_PACKAGE_TCL > menu "Tcl libraries/modules" > diff --git a/package/swipl/Config.in b/package/swipl/Config.in > new file mode 100644 > index 0000000000..f0fb2d786d > --- /dev/null > +++ b/package/swipl/Config.in > @@ -0,0 +1,38 @@ > +# swipl supports arch for which libc fenv.h provides all four macros: > +# FE_DOWNWARD, FE_TONEAREST, FE_TOWARDZERO, FE_UPWARD > +# See for example in glibc https://sourceware.org/git/glibc.git > +# git grep -E '^[[:space:]]*#[[:space:]]*define[[:space:]]+FE_(TONEAREST|UPWARD|DOWNWARD|TOWARDZERO)' sysdeps/ > +config BR2_PACKAGE_SWIPL_ARCH_SUPPORTS > + bool > + default y if BR2_aarch64 || BR2_aarch64_be > + default y if BR2_arceb || BR2_arcle > + default y if BR2_arm || BR2_armeb > + default y if BR2_i386 > + default y if BR2_m68k > + # BR2_microblaze has only FE_TONEAREST > + default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el > + # BR2_nios2 has only FE_TONEAREST > + default y if BR2_or1k > + default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le > + default y if BR2_riscv > + default y if BR2_s390x > + # BR2_sh has only FE_{TONEAREST,TOWARDZERO} > + default y if BR2_sparc || BR2_sparc64 > + default y if BR2_x86_64 > + # BR2_xtensa supports only uclibc which does not have fenv.h > + > +config BR2_PACKAGE_SWIPL > + bool "SWI-Prolog" > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # __has_attribute() > + depends on BR2_PACKAGE_SWIPL_ARCH_SUPPORTS > + # swipl needs fenv.h which is not provided by uclibc > + depends on !BR2_TOOLCHAIN_USES_UCLIBC > + select BR2_PACKAGE_ZLIB > + help > + SWI-Prolog offers a comprehensive free Prolog > + environment. Since its start in 1987, SWI-Prolog development > + has been driven by the needs of real world > + applications. SWI-Prolog is widely used in research and > + education as well as commercial applications. > + > + https://www.swi-prolog.org The Config.in comment here was missing, about the gcc >= 5 dependency and the glibc or musl dependency, so I added it. > +# swipl uses cmake macros try_run() and check_c_source_runs(), which > +# are not suitable for cross compilation. We add results in cache to > +# avoid running those tests. The SWIPL_NATIVE_FRIEND variable, is > +# meant to point to build directory of a host native swipl, rather > +# than the binary itself. The Cmake macro will append "src/swipl" to > +# the path set to this variable. Therefore, we cannot use the host > +# "swipl" binary installed in $(HOST_DIR)/usr/bin. > +SWIPL_CONF_OPTS = \ > + -DBUILD_PDF_DOCUMENTATION=OFF \ > + -DHAVE_WEAK_ATTRIBUTE=1 \ > + -DLLROUND_OK=1 \ > + -DMODF_OK=1 \ > + -DQSORT_R_GNU=1 \ > + -DSWIPL_NATIVE_FRIEND=$(BUILD_DIR)/host-swipl-$(SWIPL_VERSION) \ I've used $(HOST_SWIPL_SRCDIR) instead. Applied with those changes. Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot