Re: [Buildroot] [PATCH 1/1] boot/uboot: allow to use custom ps7_init files for zynq7000 SoC

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Taras,

On Mon, 11 Mar 2024 22:59:03 +0100
Taras Zaporozhets <zaporozhets.taras@gmail.com> wrote:

> Similar to zynqmp, add an option to pass init files from the outside.
> 
> Signed-off-by: Taras Zaporozhets <zaporozhets.taras@gmail.com>

Thanks for your patch, and sorry for the long delay in getting back to
you.

> +ifeq ($(BR2_TARGET_UBOOT_ZYNQ),y)
> +
> +UBOOT_ZYNQ_PS7_INIT = $(call qstrip,$(BR2_TARGET_UBOOT_ZYNQ_PS7_INIT_FILE))
> +UBOOT_ZYNQ_PS7_INIT_PATH = $(shell readlink -f $(UBOOT_ZYNQ_PS7_INIT))
> +
> +ifneq ($(UBOOT_ZYNQ_PS7_INIT),)
> +define UBOOT_ZYNQ_KCONFIG_PS7_INIT
> +	$(call KCONFIG_SET_OPT,CONFIG_XILINX_PS_INIT_FILE,"$(UBOOT_ZYNQ_PS7_INIT_PATH)")
> +endef
> +endif
> +
> +endif # BR2_TARGET_UBOOT_ZYNQ

However, I believe this patch is not really necessary. Unless I'm
missing something, it is just defining a particular option of the
U-Boot configuration, and we're not going to add a Buildroot option for
each and every U-Boot option. Instead, you can define this option
directly in the U-Boot configuration. If you have an existing U-Boot
configuration and don't want to touch it, you can use a "configuration
fragment" referenced by BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES to
override just this particular option.

Let me know if that would work for you?

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot