Re: [Buildroot] [PATCH v1 1/5] board/xilinx/patches/linux: add linux 6.6.40 hash

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Neal,

On Wed, 7 Aug 2024 11:58:09 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> Add the hash for the Linux 6.6.40 release for Xilinx products.
> 
> The release tag was missing a patch, so it is being added here for users that
> bump to Linux 6.6.40.  The patch has already been committed to the linux-xlnx
> repo.
> 
> Upstream: https://github.com/Xilinx/linux-xlnx/commit/5365c13a86998da06d845c918f849b30b8735538
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

I'm not sure I'm a big fan of the approach of doing this addition in
PATCH 1/5, and then changing the defconfigs one after the other. I see
two problems:

- In PATCH 1/5, you're adding a kernel patch, but do you realize that
  with only PATCH 1/5 applied, your kernel patch will be applied to the
  existing defconfigs, that use the xlnx_rebase_v6.6_LTS_2024.1 kernel ?

  It turns out you're lucky, as the patch applies fine on
  xlnx_rebase_v6.6_LTS_2024.1, but in the general case that would not
  work.

- After applying all patches, you still have the hash of
  xlnx_rebase_v6.6_LTS_2024.1.tar.gz, but I don't know if it's still
  used by some other defconfigs.

So I see several approaches here:

- Don't use a shared board/xilinx/patches/ folder, and use one per
  board, like is done in board/freescale/. This allows to update
  defconfigs independently from each other.

- Update all defconfigs that use board/xilinx/patches/ in one single
  commit.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot