Re: [Buildroot] [PATCH 00/18] Update Ejabberd and its dependencies

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Johan,

Thanks for the patch series.

On Wed,  7 Aug 2024 16:33:00 +0200
Johan Oudinet <johan.oudinet@gmail.com> wrote:

> Johan Oudinet (18):
>   package/erlang-stun: renamed from erlang-p1-stun
>   package/erlang-fast-xml: renamed from erlang-p1-xml
>   package/erlang-xmpp: renamed from erlang-p1-xmpp

I was a bit confused about these patches. I was wondering why the name
of the package mattered, and why it was influencing where the files
installed by this package are actually installed...

If I understand correctly, it all comes from:

$(2)_ERLANG_APP = $(subst -,_,$(patsubst erlang-%,%,$(patsubst host-%,%,$(1))))

which derives the ERLANG_APP name from the package name, so
erlang-p1-stun becomes p1_stun. Is that correct?

I think it's quite unique in Buildroot to do something like this. Other
packages normally install their stuff into a location that isn't
dependent on the package name chosen by Buildroot.

That being said, I assume your changes are OK, but:

- Why are we renaming only those 3 packages, and not the numerous other
  erlang-p1 packages ?

- Can we separate the rename from the bump?

- We should add Config.in.legacy entries matching the name of the old
  packages, so that the new packages get automatically selected

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot