Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>
Cc: Alexander Mukhin <alexander.i.mukhin@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/2] package/zfs: replace wip patch by upstream patch
Date: Thu, 8 Aug 2024 21:56:15 +0200	[thread overview]
Message-ID: <20240808215615.64528ebd@windsurf> (raw)
In-Reply-To: <20240808160606.60188-3-salvador.joseluis@gmail.com>

Hello José!

On Thu,  8 Aug 2024 18:06:07 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
> Changes v2 -> v3:
>     - Added Signed-off-by (suggested by Thomas Petazzoni)
> Changes v1 -> v2:
>     - Removed ZFS_AUTORECONF (suggested by Baruch Siach)

Thanks for the new iteration, which I have applied.

First comment: when you send a new iteration, don't send it as a reply
to the previous one. Send it as a new thread.

> +Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
> +Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> +Upstream: https://github.com/openzfs/zfs/pull/16413

When the patch is already merged upstream, we prefer to have here the
link to the upstream commit rather than the pull request, so I've
replaced this by the link to the final upstream commit.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-08 19:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  1:34 [Buildroot] [PATCH 1/2] package/zfs: replace wip patch by upstream patch José Luis Salvador Rufo
2024-08-07  1:34 ` [Buildroot] [PATCH 2/2] package/zfs: bump version to 2.2.5 José Luis Salvador Rufo
2024-08-07  4:26 ` [Buildroot] [PATCH 1/2] package/zfs: replace wip patch by upstream patch Baruch Siach via buildroot
2024-08-07  4:54   ` José Luis Salvador Rufo
2024-08-07  5:14   ` [Buildroot] [PATCH v2 " José Luis Salvador Rufo
2024-08-07 10:06     ` Thomas Petazzoni via buildroot
2024-08-08 16:06       ` [Buildroot] [PATCH v3 " José Luis Salvador Rufo
2024-08-08 19:56         ` Thomas Petazzoni via buildroot [this message]
2024-09-03 20:38         ` Peter Korsgaard
2024-08-08 16:06       ` [Buildroot] [PATCH v3 2/2] package/zfs: bump version to 2.2.5 José Luis Salvador Rufo
2024-08-08 19:56         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240808215615.64528ebd@windsurf \
    --to=buildroot@buildroot.org \
    --cc=alexander.i.mukhin@gmail.com \
    --cc=salvador.joseluis@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox