Re: [Buildroot] [PATCH v2 1/1] package/mjpg-streamer: fix undefined symbol error

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

On Thu,  8 Aug 2024 21:21:26 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes runtime error:
> 
>     dlopen: /usr/lib/mjpg-streamer/input_uvc.so: undefined symbol: resolutions_help
> 
> Patch was suggested by Thomas:
> http://lists.busybox.net/pipermail/buildroot/2024-August/759732.html
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Thanks, applied, two comments below.

> ---
> v2: used code suggested by Thomas, run-time tested (Thomas)
> 
>  ...-all-symbols-of-mjpg_streamer-binary.patch | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 package/mjpg-streamer/0001-Export-all-symbols-of-mjpg_streamer-binary.patch
> 
> diff --git a/package/mjpg-streamer/0001-Export-all-symbols-of-mjpg_streamer-binary.patch b/package/mjpg-streamer/0001-Export-all-symbols-of-mjpg_streamer-binary.patch
> new file mode 100644
> index 0000000000..a0b80ff711
> --- /dev/null
> +++ b/package/mjpg-streamer/0001-Export-all-symbols-of-mjpg_streamer-binary.patch
> @@ -0,0 +1,33 @@
> +From fbde1593948ae95f287b2167d0bec5b27948cc01 Mon Sep 17 00:00:00 2001
> +From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> +Date: Tue, 6 Aug 2024 17:04:55 +0200
> +Subject: [PATCH 1/1] Export all symbols of mjpg_streamer binary

Please generate the patches with git format-patch -N. Shall I suggest
that you add:

  https://paste.ack.tf/c160ab

into your .git/hooks/post-commit ? This way you will get automatic
check-package verification when you create or rework commits.

> +Fixes runtime error with stripped binary
> +
> +    dlopen: /usr/lib/mjpg-streamer/input_uvc.so: undefined symbol: resolutions_help
> +
> +Source: http://lists.busybox.net/pipermail/buildroot/2024-August/759732.html
> +
> +Upstream: https://github.com/jacksonliam/mjpg-streamer/pull/401
> +
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

This commit message is pretty terse. For me or you who have looked at
the problem, it's pretty obvious, but for the maintainer of
mjpg-streamer, it really isn't very clear what is going on and why this
patch would be needed.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot