Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next] package/bird: update to 2.15.1
Date: Mon, 12 Aug 2024 22:22:02 +0200	[thread overview]
Message-ID: <20240812222202.4b8ddc88@windsurf> (raw)
In-Reply-To: <ZrhlT1NAkvCmXNAS@waldemar-brodkorb.de>

Hello,

+Fabrice in Cc, as there is a request below :-)

On Sun, 11 Aug 2024 09:16:31 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> See here for a changelog:
> https://gitlab.nic.cz/labs/bird/-/blob/master/NEWS
> 
> An uClibc-ng based system needs _GNU_SOURCE in the CFLAGS to
> provide getrandom().
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Thanks, I've applied to next, but I have some comments below.

> +BIRD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE"

This seems to be a workaround for an issue in uClibc. Indeed, I don't
see in the manpage of getrandom() anything that indicates that defining
_GNU_SOURCE is needed to get the definition of getrandom(). Why uClibc
is guarding the definition of getrandom() on _GNU_SOURCE, and not glibc
or musl?

>  # 0001-configure.ac-fix-build-with-autoconf-2.70.patch
>  BIRD_AUTORECONF = YES

Could you work on upstreaming this patch perhaps? Or maybe convince
Fabrice to upstream it? :-)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-12 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-11  7:16 [Buildroot] [PATCH next] package/bird: update to 2.15.1 Waldemar Brodkorb
2024-08-12 20:22 ` Thomas Petazzoni via buildroot [this message]
2024-08-13  4:38   ` Waldemar Brodkorb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812222202.4b8ddc88@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox