From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/iproute2: fix musl compile errors
Date: Wed, 14 Aug 2024 22:19:50 +0200 [thread overview]
Message-ID: <20240814221950.458101ad@windsurf> (raw)
In-Reply-To: <Zrz+JUwTsNaKI8sK@waldemar-brodkorb.de>
Hello Waldemar,
I've applied to master, but I have a couple of nitpicks, and one real
request.
On Wed, 14 Aug 2024 20:57:41 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Add two patches to fix musl compile errors.
>
> Fixes:
> - http://autobuild.buildroot.net/results/8d7/8d713bd911f8d6b97272a7bb5dc2c188aeb99b05
^^^^ you can drop this part of the URL
Also, there should be an empty line *before* the Signed-off-by line.
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> ...laration-of-function-htobe64-in-gcc-.patch | 43 +++++++++++++++++++
> ...laration-of-function-basename-in-gcc.patch | 30 +++++++++++++
> 2 files changed, 73 insertions(+)
> create mode 100644 package/iproute2/0001-Fix-implicit-declaration-of-function-htobe64-in-gcc-.patch
> create mode 100644 package/iproute2/0002-Fix-implicit-declaration-of-function-basename-in-gcc.patch
> +From Alpine Linux.
> +
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> +Upstream: https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/iproute2/basename.patch?ref_type=heads
This really isn't an "Upstream:" URL, it's really a "downstream" thing.
Indeed, what we want to see is patches submitted to the upstream
project, so that at some point in the future, we can drop them from
Buildroot.
So could you submit this patch to the upstream iproute2 project, and
then updated the link in this patch?
"man 3 basename" says <libgen.h> should be included for get the
prototype for basename(), so it shouldn't be too difficult to convince
upstream that it's the right thing to do, and not just a musl-related
fix.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-14 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 18:57 [Buildroot] [PATCH] package/iproute2: fix musl compile errors Waldemar Brodkorb
2024-08-14 20:19 ` Thomas Petazzoni via buildroot [this message]
2024-08-15 7:22 ` Waldemar Brodkorb
2024-08-15 8:07 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814221950.458101ad@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox