Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next v3] package/bind: update to 9.18.28
Date: Sun, 18 Aug 2024 18:57:18 +0200	[thread overview]
Message-ID: <20240818165718.GA719477@pevik> (raw)
In-Reply-To: <Zr6t0edkFUlZULGn@waldemar-brodkorb.de>

Hi Waldemar,

thanks for the update, LGTM!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

BTW (not related to this change), startup script produces some warnings, it'd be
nice to fix them (as a separate effort:

$ ./utils/check-package package/bind/*
package/bind/S81named:4: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
package/bind/S81named:11: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
package/bind/S81named:12: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
package/bind/S81named:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
package/bind/S81named:14: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
package/bind/S81named:0: run 'shellcheck' and fix the warnings

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-18 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16  1:39 [Buildroot] [PATCH next v3] package/bind: update to 9.18.28 Waldemar Brodkorb
2024-08-18 16:57 ` Petr Vorel [this message]
2024-09-11 19:40 ` Arnout Vandecappelle via buildroot
2024-09-19 11:16   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240818165718.GA719477@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox