From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS
Date: Mon, 19 Aug 2024 12:48:18 +0200 [thread overview]
Message-ID: <20240819124818.1de270f6@windsurf> (raw)
In-Reply-To: <20240819084352.905082-1-james.hilliard1@gmail.com>
On Mon, 19 Aug 2024 02:43:52 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Flashrom requires --default-library=both for the cli when building
> with BR2_SHARED_LIBS.
>
> As such set --default-library=both instead of disabling it.
>
> The cli was disabled in 8637884057ddc3c1aeb9f0dd285fc6fcf378c26b to
> work around a cli build issue which this fixes.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
> - add some additional details
> ---
> package/flashrom/flashrom.mk | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-19 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 8:43 [Buildroot] [PATCH v2 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS James Hilliard
2024-08-19 10:48 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819124818.1de270f6@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox