Re: [Buildroot] [PATCH 1/2] package/wpa_supplicant: wired driver needs headers >= 5.7

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sergey Matyukevich <geomatsi@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/wpa_supplicant: wired driver needs headers >= 5.7
Date: Mon, 19 Aug 2024 12:59:36 +0200	[thread overview]
Message-ID: <20240819125936.33b32adf@windsurf> (raw)
In-Reply-To: <20240818203134.1512793-2-geomatsi@gmail.com>

Hello Sergey,

On Sun, 18 Aug 2024 23:31:29 +0300
Sergey Matyukevich <geomatsi@gmail.com> wrote:

> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 92953f69f0..e013f5a9c1 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -42,7 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>  	bool "Enable wired support"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_7

Thanks, but it seems a bit drastic.

If I looked at the code:

ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
WPA_SUPPLICANT_CONFIG_ENABLE += \
        CONFIG_LIBNL32 \
        CONFIG_DRIVER_WIRED \
        CONFIG_MACSEC \
        CONFIG_DRIVER_MACSEC_LINUX

so it forces CONFIG_DRIVER_MACSEC_LINUX, what about making that
dependent on kernel headers >= 5.7, rather than preventing the whole
wired driver from being compiled?

Or, in fact even better, in ./src/drivers/driver_macsec_linux.c, change:

#if LIBNL_VER_NUM >= LIBNL_VER(3, 6)
#define LIBNL_HAS_OFFLOAD
#endif

to:

#if LIBNL_VER_NUM >= LIBNL_VER(3, 6) && LINUX_VERSION_CODE >= KERNEL_VERSION(5,7,0)
#define LIBNL_HAS_OFFLOAD
#endif

And that should only enable the offload support... when it can really
be supported. Could you check this?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot