From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vincent Jardin <vjardin@free.fr>
Cc: peter@digitalbrains.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lsuio: bump to 2020 version
Date: Tue, 20 Aug 2024 23:38:30 +0200 [thread overview]
Message-ID: <20240820233830.5927db8d@windsurf> (raw)
In-Reply-To: <20240820085848.4242-1-vjardin@free.fr>
Hello Vincent,
Thanks for this update, see below some comments.
On Tue, 20 Aug 2024 10:58:48 +0200
Vincent Jardin <vjardin@free.fr> wrote:
> diff --git a/package/lsuio/lsuio.mk b/package/lsuio/lsuio.mk
> index 193de15aef..4d5cf35bcf 100644
> --- a/package/lsuio/lsuio.mk
> +++ b/package/lsuio/lsuio.mk
> @@ -4,8 +4,9 @@
> #
> ################################################################################
>
> -LSUIO_VERSION = 0.2.0
> -LSUIO_SITE = http://www.osadl.org/projects/downloads/UIO/user
> +LSUIO_VERSION = HEAD
You can't use "HEAD" because this is a moving thing: if you build today
and tomorrow and there's a commit made upstream, you will build
something different. If there are no tags, please use a fixed commit
hash.
> +LSUIO_SITE = https://github.com/DigitalBrains1/lsuio.git
Please use $(call github,DigitalBrains1,lsuio,$(LSUIO_VERSION))
see other packages.
> +LSUIO_SITE_METHOD = git
This can be dropped if you use $(call github,...).
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-20 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 8:58 [Buildroot] [PATCH 1/1] package/lsuio: bump to 2020 version Vincent Jardin
2024-08-20 21:38 ` Thomas Petazzoni via buildroot [this message]
2024-08-21 9:50 ` [Buildroot] [PATCH v2 0/1] " Vincent Jardin
2024-08-21 9:50 ` [Buildroot] [PATCH v2 1/1] " Vincent Jardin
2024-08-24 19:00 ` Thomas Petazzoni via buildroot
2024-08-24 20:34 ` Vincent Jardin
2024-08-26 12:04 ` Peter Lebbing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820233830.5927db8d@windsurf \
--to=buildroot@buildroot.org \
--cc=peter@digitalbrains.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox