Re: [Buildroot] [PATCH 1/1] package/busybox: patch to fix tc build on 6.8+ kernels

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 23 Aug 2024 05:09:39 -0400
Un1q32 <joey.t.reinhart@gmail.com> wrote:

> Signed-off-by: Un1q32 <joey.t.reinhart@gmail.com>

Thanks a lot for the patch!

We need patches to be sent with a real-name... especially when in fact
your real name is clearly visible in your e-mail address.

> diff --git a/package/busybox/0010-tc-build-fails-on-kernel-6.8.patch b/package/busybox/0010-tc-build-fails-on-kernel-6.8.patch
> new file mode 100644
> index 0000000000..95f2585c21
> --- /dev/null
> +++ b/package/busybox/0010-tc-build-fails-on-kernel-6.8.patch
> @@ -0,0 +1,55 @@
> +http://lists.busybox.net/pipermail/busybox/2024-March/090678.html
> +https://bugs.gentoo.org/926872
> +
> +Linux v6.8-rc1 removed the definitions related to CBQ making tc fail to
> +build. Add some #ifdefs to handle this missing support.
> +
> +Signed-off-by: Un1q32 <joey.t.reinhart@gmail.com>

Could you please send a patch generated by Git format-patch, and that
keep the original authorship? It should have an Upstream: tag pointing
to where it has been submitted upstream, and indeed your Signed-off-by
line.

See
package/busybox/0009-menuconfig-gcc-failing-saying-ncurses-is-not-found.patch
for an example where it has been done the way we expect.

Could you come up with a v2 of your patch that addresses those small
details?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot